Flake8: Remove E741 #4558
Flake8: Remove E741 #4558
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4558 +/- ##
==========================================
- Coverage 84.56% 84.54% -0.02%
==========================================
Files 164 164
Lines 9923 9922 -1
Branches 1476 1475 -1
==========================================
- Hits 8391 8389 -2
Misses 1266 1266
- Partials 266 267 +1
|
|
@elacuesta there are conflicts here |
|
Updated, but the build will fail until we merge #4572, let's wait for that one. |
| b.append(" fetch(req) " | ||
| "Fetch a scrapy.Request and update local objects ") | ||
| b.append(" shelp() Shell help (print this help)") | ||
| b.append(" view(response) View response in a browser") | ||
|
|
||
| return "\n".join("[s] %s" % l for l in b) | ||
| return "\n".join("[s] %s" % line for line in b) |
There was a problem hiding this comment.
Hi @elacuesta
Maybe it's not necessary to do it as part of this PR, but as we are giving more meaning to a lot of variable names, it could be a good idea to rename this b variable to something like banner (I assume this is the real meaning by looking at this: self.vars['banner'] = self.get_help()) or help_lines.
There was a problem hiding this comment.
Indeed, I almost did that, but I decided not to in order to keep the diff simpler. Perhaps we can do it in a later PR 👍
elacuesta
force-pushed
the
flake8-remove-e741
branch
from
200ad2a
to
15d9e01
Compare
|
Rebased on top of #4572 |
elacuesta
force-pushed
the
flake8-remove-e741
branch
from
15d9e01
to
df8a1d1
Compare
|
Updated, reverted changes to |
|
hi @elacuesta is there something blocking to work on |
Do not use variables named 'I', 'O', or 'l'