Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete conversion to f-strings #5245

Closed
wRAR opened this issue Sep 23, 2021 · 3 comments · Fixed by #5246
Closed

Complete conversion to f-strings #5245

wRAR opened this issue Sep 23, 2021 · 3 comments · Fixed by #5246
Assignees
@GeorgeA92
Labels
CI cleanup

Comments

@wRAR
Copy link
Member

wRAR commented Sep 23, 2021

Recent pylint started detecting potential f-string usages, I think it's fine to keep this error and just convert the remaining usages. pylint output can be seen at https://github.com/scrapy/scrapy/pull/5244/checks?check_run_id=3671950402
@GeorgeA92
Copy link
Contributor

I received the same log entries from pylint after recent update of my PR 4792 https://github.com/scrapy/scrapy/pull/4972/checks?check_run_id=3633586376.
I can take it.

@GeorgeA92 GeorgeA92 mentioned this issue Sep 23, 2021
Merged
NeelSagar39 added a commit to NeelSagar39/scrapy that referenced this issue Sep 24, 2021
@NeelSagar39
fix: Update to f-string
517a494 
An update for the issue scrapy#5245
@NeelSagar39 NeelSagar39 mentioned this issue Sep 24, 2021
Closed
@ghost
Copy link

ghost commented Oct 1, 2021

I can fix this, can have it assigned.

@wRAR
Copy link
Member Author

wRAR commented Oct 1, 2021

@tpush as you can see above there is already an open PR for this.

@HTsuyoshi HTsuyoshi mentioned this issue Oct 6, 2021
Closed
@wRAR wRAR mentioned this issue Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgeA92 GeorgeA92

Labels
CI cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5245 f-strings GeorgeA92/scrapy
3 participants
@wRAR @Gallaecio @GeorgeA92