Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTMLImageLinkExtractor to work with libxml2 and lxml selectors #119

Merged
merged 2 commits into from
Apr 19, 2012
Merged

Fix HTMLImageLinkExtractor to work with libxml2 and lxml selectors #119

merged 2 commits into from
Apr 19, 2012

Conversation

andrix
Copy link
Contributor

@andrix andrix commented Apr 18, 2012

Hi guys, as I told you today about this issue, here is the PR with:

  • a new test that fail when the location is an lxml selector object,
  • a fix on HTMLImageLinkExtractor, also make it work using select only as Daniel suggested
  • fix an existing test, that one of the link was an .html file on an equality test, so it was against the class goal (extract image links from an html).

Let me know what you think.

Andrés

P.S: /me hopes this time @pablo see the PR :P

pablohoffman added a commit that referenced this pull request Apr 19, 2012
@pablohoffman
Merge pull request #119 from andrix/fix-htmlimagelinkextractor
13ac6f6 
Fix HTMLImageLinkExtractor to work with libxml2 and lxml selectors
@pablohoffman pablohoffman merged commit 13ac6f6 into scrapy:master Apr 19, 2012
lucywang000 pushed a commit to lucywang000/scrapy that referenced this pull request Feb 24, 2019
@sibiryakov
Merge pull request scrapy#119 from Vlsarro/patch-2
bfa56df 
fixing the link to 'Frontier at a glance'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrix @pablohoffman @dangra