New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase delay of defer calls #1253
Conversation
… cycles to accomplish its needs.
return d | ||
|
||
def defer_succeed(result): | ||
"""Same as twsited.internet.defer.succed, but delay calling callback until | ||
"""Same as twsited.internet.defer.succed but delay calling callback until |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in twisted and succeed
LGTM, let's fix the minor typos |
fixed. 2015-05-22 19:59 GMT-03:00 Pablo Hoffman notifications@github.com:
|
Increase delay of defer calls
Why not push it to master? Hm, why did we create 1.0 branch? In past we were branching when a bug-fix release was needed, no? |
do you mean pushing to master and backporting to 1.0? I wasn't sure what option to follow, pushing to 1.0 and porting to master or the other way. I think in the past we pushed to master and backported which makes more sense now that I think. I will port it to master now.
No, in the past we created a branch for every next stable release and released bugfixes from that branch. The release procedure is described at https://github.com/scrapy/scrapy/wiki/Scrapy-release-procedure#version-and-git-branch |
closes #1075 and #1074