Remove deprecated %z formatting from the default LOG_DATEFORMAT #1278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1270
Not sure if the timezone is going to be missed from the logs (twisted logging had it) and I'm not entirely sure why windows is expanding it to contain non-ascii chars as reported in the issue, but '%z' time formatting is deprecated as stated here:
https://docs.python.org/2/library/time.html#id2[EDIT: I misread it, but is not listed in https://docs.python.org/2/library/time.html#time.strftime so it seems it's not officially supported], so it's probably safer to just remove it. '%Y-%m-%d %H:%M:%S' is the default datefmt for 'asctime' if there isn't one specified as well.Note that this change just aims to have a sane default, since this is really a python logging issue. Users could still set LOG_DATEFORMAT to whatever they want, but they'll have to deal with the issues the python logging could arise.