Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] port some downloader middlewares to Python 3 #1470

Merged
merged 6 commits into from Sep 2, 2015
Merged

[MRG] port some downloader middlewares to Python 3 #1470

merged 6 commits into from Sep 2, 2015

Conversation

kmike
Copy link
Member

@kmike kmike commented Aug 31, 2015

Easy stuff, mostly fixing tests.

@codecov-io
Copy link

Current coverage is 82.23%

Merging #1470 into master will decrease coverage by -0.01% as of 02e0407

@@            master   #1470   diff @@
======================================
  Files          158     158       
  Stmts         8225    8225       
  Branches      1140    1140       
  Methods          0       0       
======================================
- Hit           6765    6764     -1
- Partial        264     265     +1
  Missed        1196    1196

Review entire Coverage Diff as of 02e0407

Powered by Codecov. Updated on successful CI builds.

@kmike kmike changed the title port some downloader middlewares to Python 3 [MRG] port some downloader middlewares to Python 3 Sep 1, 2015
dangra added a commit that referenced this pull request Sep 2, 2015
@dangra
Merge pull request #1470 from scrapy/py3-middlewares
3919ad6 
[MRG] port some downloader middlewares to Python 3
@dangra dangra merged commit 3919ad6 into master Sep 2, 2015
@dangra dangra deleted the py3-middlewares branch September 2, 2015 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmike @codecov-io @dangra