[MRG+1] PY3: Fix SitemapSpider to extract sitemap urls from robots.txt properly #1767
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
eliasdorneles
changed the title
|
Thanks for the patch @orangain, looks good! 👍 |
|
Thanks @orangain! |
kmike
added a commit
that referenced
this pull request
Feb 8, 2016
[MRG+1] PY3: Fix SitemapSpider to extract sitemap urls from robots.txt properly
|
Needs backporting to 1.1 branch |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #1766, the problem that SitemapSpider fails to extract sitemap urls from robots.txt in Python 3.
Changes
response.textas an argument ofsitemap_urls_from_robots()instead ofresponse.body.