Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] added faq entry regarding ssl errors on osx #1909

Closed
wants to merge 1 commit into from

Conversation

kneufeld
Copy link

@kneufeld kneufeld commented Apr 7, 2016

@redapple here's that pull request you... requested.

@redapple redapple changed the title added faq entry regarding ssl errors on osx [MRG+1] added faq entry regarding ssl errors on osx Apr 8, 2016

The current version of Scrapy (1.0.5) also has issues that will
be addressed in version 1.1, so we'll need to install the release
candidate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't make much sense to document Scrapy 1.0.5 limitations in Scrapy master branch because these docs would be docs for Scrapy 1.1 (or 1.2?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, we shouldn't suggest installing 1.1.0rc3 here because by the time these docs are default 1.1 should be already released.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I'd say we're at a bit of a catch-22 then. Since the current version is broken, the next one is not but to publish this guide you need a new version.

Merge it or not or edit it or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is 1.0 branch; I think a PR which mentions 1.0 limitations should be agains this branch, not against master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmike , not sure I'm following. This is about limitations because of OS X 's OpenSSL version, that are still there for Scrapy 1.1.
Am I missing something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point is about this note:

The current version of Scrapy (1.0.5) also has issues that will
be addressed in version 1.1, so we'll need to install the release
candidate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this can be removed. and say pip install Scrapy instead now.

@Gallaecio
Copy link
Member

Closing since OS X El Capitan is not supported since August 2018.

@Gallaecio Gallaecio closed this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants