-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+1] added faq entry regarding ssl errors on osx #1909
Conversation
|
||
The current version of Scrapy (1.0.5) also has issues that will | ||
be addressed in version 1.1, so we'll need to install the release | ||
candidate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it doesn't make much sense to document Scrapy 1.0.5 limitations in Scrapy master branch because these docs would be docs for Scrapy 1.1 (or 1.2?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, we shouldn't suggest installing 1.1.0rc3 here because by the time these docs are default 1.1 should be already released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I'd say we're at a bit of a catch-22 then. Since the current version is broken, the next one is not but to publish this guide you need a new version.
Merge it or not or edit it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is 1.0 branch; I think a PR which mentions 1.0 limitations should be agains this branch, not against master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmike , not sure I'm following. This is about limitations because of OS X 's OpenSSL version, that are still there for Scrapy 1.1.
Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point is about this note:
The current version of Scrapy (1.0.5) also has issues that will
be addressed in version 1.1, so we'll need to install the release
candidate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, this can be removed. and say pip install Scrapy
instead now.
Closing since OS X El Capitan is not supported since August 2018. |
@redapple here's that pull request you... requested.