Checking if defer gets an error callback while in start_request and killing process #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 83.48% (diff: 53.84%)
|
| d = self.crawler_process.crawl(spname, **opts.spargs) | ||
|
|
||
| def _crawl_error(_exc): | ||
| global exception |
There was a problem hiding this comment.
Is it a way to have a mutable variable in a closure (i.e. something what nonlocal keyword does in Python 3)? If so, I think it is better to use another workaround, e.g. using a list of length 1 and changing its first item.
|
Rasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to account for the case that an exception is being raised in the start_requests method. In
scrapy/crawler.py:Crawler/crawlthe values yielded are left unused.scrapy/commands/crawl.py:Command.rundoes nothing with the deferred that is yielded. This fix checks if an error is raised and callssys.exit(1)if it is. The stack-trace leading to the error is also logged.This has been tracked in issue 1231 and 1241.