[MRG+1] [image & file pipeline] loading setting for user classes #2243
Conversation
if user has some custom subclass of Image pipeline and no setting for this pipeline, he should get default settings defined for Image Pipeline. Fixes #2198
Current coverage is 83.36% (diff: 100%)
|
|
@briehanlombaard , would you be able to test the fix on your end too? |
|
@redapple That fixes the problem. Thanks! |
redapple
changed the title
|
Thank you for checking @briehanlombaard (and reporting before that!) |
|
@kmike @eliasdorneles , do you agree with the change? |
|
Yup, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
if user has some custom subclass of Image pipeline and no setting for
this pipeline, he should get default settings defined for Image Pipeline.
Fixes #2198