Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Added documentation about accessing header values #2327

Merged
merged 2 commits into from Oct 20, 2016

Conversation

@bopace
Copy link
Contributor

@bopace bopace commented Oct 17, 2016

Adds documentation to resolve #2320

@codecov-io
Copy link

@codecov-io codecov-io commented Oct 17, 2016

Current coverage is 83.31% (diff: 100%)

Merging #2327 into master will not change coverage

@@             master      #2327   diff @@
==========================================
  Files           161        161          
  Lines          8721       8721          
  Methods           0          0          
  Messages          0          0          
  Branches       1284       1284          
==========================================
  Hits           7266       7266          
  Misses         1204       1204          
  Partials        251        251          

Powered by Codecov. Last update 7e20725...fd016ee

@@ -507,7 +507,13 @@ Response objects

.. attribute:: Response.headers

A dictionary-like object which contains the response headers.
A dictionary-like object which contains the response headers. Values can
be accessed from the :class:`headers` object by using :meth:`get` to
Copy link
Contributor

@redapple redapple Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "from the :class:headers object by" is necessary

Copy link
Member

@eliasdorneles eliasdorneles Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, that's not resolving to a proper link -- no need to use special markup here, just headers is good.

Copy link
Contributor Author

@bopace bopace Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up. I committed a fix just now.

@redapple
Copy link
Contributor

@redapple redapple commented Oct 18, 2016

Thanks @bopace ! I nitpicked a little.

@bopace
Copy link
Contributor Author

@bopace bopace commented Oct 18, 2016

Thanks! How does that change look?

@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Oct 18, 2016

Looks good, thanks @bopace !

@eliasdorneles eliasdorneles changed the title Added documentation about accessing header values [MRG+1] Added documentation about accessing header values Oct 18, 2016
@kmike kmike merged commit 871eec9 into scrapy:master Oct 20, 2016
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants