[MRG+1] Added documentation about accessing header values #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 83.31% (diff: 100%)@@ master #2327 diff @@
==========================================
Files 161 161
Lines 8721 8721
Methods 0 0
Messages 0 0
Branches 1284 1284
==========================================
Hits 7266 7266
Misses 1204 1204
Partials 251 251
|
redapple
reviewed
Oct 18, 2016
| @@ -507,7 +507,13 @@ Response objects | |||
|
|
|||
| .. attribute:: Response.headers | |||
|
|
|||
| A dictionary-like object which contains the response headers. | |||
| A dictionary-like object which contains the response headers. Values can | |||
| be accessed from the :class:`headers` object by using :meth:`get` to | |||
There was a problem hiding this comment.
I don't think "from the :class:headers object by" is necessary
There was a problem hiding this comment.
yup, that's not resolving to a proper link -- no need to use special markup here, just headers is good.
There was a problem hiding this comment.
Thanks for the heads up. I committed a fix just now.
|
Thanks @bopace ! I nitpicked a little. |
|
Thanks! How does that change look? |
|
Looks good, thanks @bopace ! |
eliasdorneles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation to resolve #2320