[MRG+1] Mention PyPy support, add PyPy to install docs #3048
Conversation
| @@ -69,9 +69,11 @@ Here's an example spider using BeautifulSoup API, with ``lxml`` as the HTML pars | |||
| What Python versions does Scrapy support? | |||
| ----------------------------------------- | |||
|
|
|||
| Scrapy is supported under Python 2.7 and Python 3.4+. | |||
| Scrapy is supported under Python 2.7 and Python 3.4+ | |||
| under CPython (default Python implementation) and PyPy (only for Python 2.7). | |||
There was a problem hiding this comment.
Do you know what's the reason pypy3 is not supported? Is it just us not running tests for it, or are there things which work in pypy2, but not in pypy3?
There was a problem hiding this comment.
Last time I checked, lxml did not install on PyPy 3. I filed an issue about it and it was quickly fixed, but then it stopped working again. I didn't check in a while though, let me check again.
kmike
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3048 +/- ##
=======================================
Coverage 84.51% 84.51%
=======================================
Files 164 164
Lines 9270 9270
Branches 1380 1380
=======================================
Hits 7835 7835
Misses 1177 1177
Partials 258 258 |
|
Turned out that scrapy 1.4.0 didn't have that pypy-specific dependency yet, and if I build a wheel from master and install it locally, then PyPyDispatcher is picked up correctly - hopefully this will be the same for the wheel for 1.5.0 (I checked that py27 build installs setuptools-38.2.5 which is more than enough for this feature to work). |
| If this command gives errors such as | ||
| ``TypeError: ... got 2 unexpected keyword arguments``, this means | ||
| that setuptools was unable to pick up one PyPy-specific dependency. | ||
| To fix this issue, run ``pip install 'PyPyDispatcher>=2.1.0'``. |
There was a problem hiding this comment.
@lopuhin do you prefer to keep this note, just in case, or to remove it?
There was a problem hiding this comment.
I'd rather keep it just in case. In theory pypy comes with a recent enough setuptools, but I remember that someone still had this issue somehow (although that could be with 1.4.0 which I thought already had this feature). If we don't get any reports about this, we can remove it in the next release.
|
Looks good! Let's tackle pypy3 separately. |
As discussed in #2213, mention that we have PyPy support, and describe installation issues. I put PyPy section at the end, along with platform issues, although it's not strictly a platform.
I discovered one issue though that I'll try to resolve in another PR: right now pypy-specific dependency PyPyDispatcher is never picked up. A way to check and a workaround is also in the docs, but not everyone reads them so I'd like to try fixing this before release.