Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Update Scrapy Tutorial docs #3468

Merged
merged 2 commits into from Nov 5, 2018

Conversation

@ilhaoni
Copy link
Contributor

@ilhaoni ilhaoni commented Oct 17, 2018

Hi there!

This is my pull request referencing the issue #3464.

I've removed the ad link "Dive into Python 3", and replaced it with Crash into Python. It seems like a good resource for people to get up to speed with Python quickly.

Alternatively, I can just remove the link as well and point people to The Python Tutorial.

Thanks!

@stummjr
Copy link
Member

@stummjr stummjr commented Nov 2, 2018

Hey @ilhaoni, thanks for your contribution! :)

IMO, we could just remove the "dive into python" reference for now and keep the "python tutorial" one only. Hopefully, it comes back soon. 🤞

Personally, I don't know much about "Crash into Python" to vouch for its inclusion as a reference.

@ilhaoni ilhaoni closed this Nov 4, 2018
@ilhaoni
Copy link
Contributor Author

@ilhaoni ilhaoni commented Nov 4, 2018

Hi @stummjr, glad to be able to contribute! 😄

I understand, that's a good point. I've removed the "Crash into Python 3" reference, and kept only the "Python Tutorial" reference.

We can make changes again once the "Dive into Python 3" is back~

@ilhaoni ilhaoni reopened this Nov 4, 2018
@ilhaoni
Copy link
Contributor Author

@ilhaoni ilhaoni commented Nov 4, 2018

PS: I accidentally clicked "close issue" on my side, my bad.

Have already reopened the issue!

@stummjr stummjr changed the title Update Scrapy Tutorial docs [MRG+1] Update Scrapy Tutorial docs Nov 5, 2018
@kmike kmike merged commit dc65e75 into scrapy:master Nov 5, 2018
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Nov 5, 2018

Thanks @ilhaoni and @stummjr!

@kmike kmike added this to the v1.6 milestone Nov 5, 2018
@kmike kmike added the docs label Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants