Allowed partial response on timeout if fail on dataloss is set to false #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3492 +/- ##
==========================================
+ Coverage 84.38% 84.39% +0.01%
==========================================
Files 167 167
Lines 9376 9383 +7
Branches 1392 1393 +1
==========================================
+ Hits 7912 7919 +7
Misses 1206 1206
Partials 258 258
|
|
@kmike Can you please review it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
DOWNLOAD_FAIL_ON_DATALOSSis set to true in settings ant the request times out we need partial responses, as discussed here #3407I've added a new callback in the above-mentioned case instead of canceling the
Deferredand returned the result instead of raising a TimeoutError.Resolves #3407