Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Add a troubleshooting section to the installation instructions #3517

Merged
merged 1 commit into from Dec 6, 2018

Conversation

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Dec 3, 2018

Its initial content covers the workaround for #2473.

Its initial content covers the workaround for #2473.
@lopuhin
lopuhin approved these changes Dec 3, 2018
Copy link
Member

@lopuhin lopuhin left a comment

I checked the original issue, looks good to me, thanks @Gallaecio 👍

@codecov
Copy link

@codecov codecov bot commented Dec 3, 2018

Codecov Report

Merging #3517 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3517   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files         167      167           
  Lines        9376     9376           
  Branches     1392     1392           
=======================================
  Hits         7912     7912           
  Misses       1206     1206           
  Partials      258      258
@lopuhin lopuhin changed the title Add a troubleshooting section to the installation instructions [MRG+1] Add a troubleshooting section to the installation instructions Dec 3, 2018
@kmike kmike merged commit e766bde into scrapy:master Dec 6, 2018
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 886513c...274b65d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike
Copy link
Member

@kmike kmike commented Dec 6, 2018

Thanks @Gallaecio!

@kmike kmike added this to the v1.6 milestone Dec 12, 2018
@kmike kmike added the docs label Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants