Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs/topics/ubuntu.rst #3684

Merged
merged 1 commit into from Jul 12, 2019
Merged

Conversation

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Mar 15, 2019

I think it is the logical step after #2137.

This change should probably be accompanied by the closing of pull request #1439, which is about changing the page removed here.

Closes #1438, closes #1439

@codecov
Copy link

@codecov codecov bot commented Mar 15, 2019

Codecov Report

Merging #3684 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3684   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files         167      167           
  Lines        9410     9410           
  Branches     1397     1397           
=======================================
  Hits         7954     7954           
  Misses       1199     1199           
  Partials      257      257

@kmike
Copy link
Member

@kmike kmike commented Jun 25, 2019

I'm fine with this. @dangra any objections?

@Gallaecio Gallaecio merged commit fa6a0d7 into scrapy:master Jul 12, 2019
3 checks passed
@dangra
Copy link
Member

@dangra dangra commented Jul 13, 2019

Go for it! oh.. it happened already 😱 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants