Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reactor.py, updated 'if' sequencing . #3937

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Update reactor.py, updated 'if' sequencing . #3937

merged 1 commit into from
Nov 19, 2019

Commits on Aug 5, 2019

  1. Update reactor.py, updated 'if' sequencing , possibly eliminating a b… 

    …ug if portrange=None

This should be the proper ordering.This is the explanation.
  If 'not portrange' is True ,it is guaranteed that `not hasattr(portrange, '__iter__')`  is also True  the converse of this is not always true.(for example, consider portrange=None, for such case we were executing the logic for `not hasattr(portrange, '__iter__')` . ).Such case is eliminated by this PR.
    @sbs2001
    sbs2001 committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    18d0aff View commit details
    Browse the repository at this point in the history