refactor LogStats extension to log IPM and RPM to stats on spider_close #4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurnzZ
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4111 +/- ##
==========================================
+ Coverage 88.55% 88.61% +0.05%
==========================================
Files 160 161 +1
Lines 11607 11775 +168
Branches 1883 1908 +25
==========================================
+ Hits 10279 10434 +155
- Misses 1003 1011 +8
- Partials 325 330 +5
|
BurnzZ
changed the title
|
The feature looks good to me, but it needs an update to the current master branch. |
BurnzZ
force-pushed
the
refactor-LogStats
branch
from
64daeff
to
d25909e
Compare
|
Thanks for unearthing this @kmike as I totally forgot about it 😅 . I've added tests and rebased the PR to master. |
kmike
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4110
NOTE: I noticed that the
LogStatsextension doesn't have any tests at all. I will write the tests later when this refactoring approach is approved.