Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe command (fix issue #33) #413

Closed
wants to merge 29 commits into from
Closed

Conversation

pedrofaustino
Copy link

Here's a first take at adding the probe command. Please review and comment.

How can we use the MockServer to add tests?

@pedrofaustino pedrofaustino mentioned this pull request Oct 4, 2013
@nramirezuy
Copy link
Contributor

I don't get the use case of this command, can you illustrate me?

@srmaximiano
Copy link

See issue description on #33


Usage examples::

$ scrapy probe 'http://www.example.com/some/page.html' 'var sFeatures'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That url responds and not have the text searched, can be confusing.

@nramirezuy
Copy link
Contributor

I think we need a way to get a set of headers per scrapy project.
I kind of dislike the headers hard coded on the class, can you add them to default_settings.py?

@nramirezuy
Copy link
Contributor

@dangra Anything preventing this to be merged? Besides __future__.print_function

probe
-----

.. versionadded:: 0.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be 0.25 or 0.26, I'm not sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.26

@eLRuLL
Copy link
Member

eLRuLL commented Dec 27, 2018

related issue #33 was closed as there isn't a necessity for this feature to leave inside scrapy and there is already a tool that can be used for the same functionality: minreq

Closing this PR.

@eLRuLL eLRuLL closed this Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants