Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a non-zero exit code when a pipeline's open_spider method throws an exception #4207

Merged
merged 25 commits into from
Feb 25, 2020
Merged

Use a non-zero exit code when a pipeline's open_spider method throws an exception #4207

merged 25 commits into from
Feb 25, 2020

Commits on Dec 4, 2019

  1. fix issue 4175 - Scrapy does not use a non-zero exit code when pipeli… 

    …ne's open_spider throws the exception
    @kevin-sb
    kevin-sb committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    9340151 View commit details
    Browse the repository at this point in the history

  2. remove extra blank lines

    @kevin-sb
    kevin-sb committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    c422ed9 View commit details
    Browse the repository at this point in the history

  3. remove redundant code

    @kevin-sb
    kevin-sb committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    d0b09e5 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2019

  1. remove blank line at end of file

    @kevin-sb
    kevin-sb committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    701a25b View commit details
    Browse the repository at this point in the history

  2. more suitable naming for response and make if-condition shorter

    @kevin-sb
    kevin-sb committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    1166996 View commit details
    Browse the repository at this point in the history

  3. avoid error - AttributeError: 'Deferred' object has no attribute 'res… 

    …ult'
    @kevin-sb
    kevin-sb committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    b027abd View commit details
    Browse the repository at this point in the history

  4. use getattr to make code concisely

    @kevin-sb
    kevin-sb committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    733aa00 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2019

  1. add test

    @kevin-sb
    kevin-sb committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    587cb8a View commit details
    Browse the repository at this point in the history

  2. remove useless file

    @kevin-sb
    kevin-sb committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    bc83d52 View commit details
    Browse the repository at this point in the history

  3. modify test class name

    @kevin-sb
    kevin-sb committed Dec 7, 2019
    Configuration menu
    Copy the full SHA
    ad6568d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. remove unneccessary files

    @kevin-sb
    kevin-sb committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    240351e View commit details
    Browse the repository at this point in the history

  2. Fix Flake8-reported issue

    @Gallaecio
    Gallaecio committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    60ea798 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. fix these items which are suggested by Gallaecio 

    ・Sort those imports at tests/test_cmdline_crawl_with_pipeline/__init__.py
・Remove the unused setUp method.
・Remove comments generated by Scrapy’s project generation tool.
・Remove the [deploy] section from the scrapy.cfg file (I don’t think it’s needed here)
・Remove BOT_NAME and NEWSPIDER_MODULE from settings.py (I think there are not needed either, although I’m less sure about NEWSPIDER_MODULE)
    @kevin-sb
    kevin-sb committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    421f053 View commit details
    Browse the repository at this point in the history

  2. have to reserve BOT_NAME, SPIDER_MODULES in settings.py

    @kevin-sb
    kevin-sb committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    40d8a0c View commit details
    Browse the repository at this point in the history

  3. Remove unneeded empty lines

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    1a6f80b View commit details
    Browse the repository at this point in the history

  4. Empty __init__.py file with unneeded comments

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    c415a41 View commit details
    Browse the repository at this point in the history

  5. Remove an unneeded empty line at the end

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    1169d37 View commit details
    Browse the repository at this point in the history

  6. Remove unneeed empty line from __init__.py file

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    837f498 View commit details
    Browse the repository at this point in the history

  7. Update __init__.py

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    d67e01d View commit details
    Browse the repository at this point in the history

  8. Update __init__.py

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    ca64bf2 View commit details
    Browse the repository at this point in the history

  9. Update exception.py

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    cfad818 View commit details
    Browse the repository at this point in the history

  10. Update normal.py

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    fd39253 View commit details
    Browse the repository at this point in the history

  11. Update __init__.py

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    fb0ff2d View commit details
    Browse the repository at this point in the history

  12. Update __init__.py

    @Gallaecio
    Gallaecio committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    66d7e8f View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. fix W391 blank line at end of file

    @kevin-sb
    kevin-sb committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    a2e57a8 View commit details
    Browse the repository at this point in the history