Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for an async callbacks that returns requests. #4316

Merged
merged 1 commit into from Feb 7, 2020

Conversation

wRAR
Copy link
Contributor

@wRAR wRAR commented Feb 7, 2020

Follow-up for #4269

@wRAR wRAR requested a review from kmike Feb 7, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 7, 2020

Codecov Report

Merging #4316 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4316      +/-   ##
==========================================
+ Coverage   83.75%   83.93%   +0.18%     
==========================================
  Files         165      165              
  Lines        9881     9881              
  Branches     1470     1470              
==========================================
+ Hits         8276     8294      +18     
+ Misses       1352     1334      -18     
  Partials      253      253              
Impacted Files Coverage Δ
scrapy/robotstxt.py 97.53% <0.00%> (+22.22%) ⬆️

@kmike kmike merged commit 0f62e44 into scrapy:master Feb 7, 2020
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Feb 7, 2020

Thanks @wRAR!

@wRAR wRAR added the asyncio label Aug 17, 2021
@wRAR wRAR deleted the asyncio-parse-request-tests branch Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants