Missing cssselect and mock requirements. #446
Conversation
requirements-lucid was not modified as perhaps cssselect is not going to work with lxml 2.2.x and python 2.6 support is not longer supported anyway.
As test_pipeline_files requires mock module, the file requirements- tests.txt was created to hold modules *needed* to run the tests. Travis' requirements already includes the mock module, but there is no hint in the root tree that mock module is required. This new file will help new contributors to quickly find which modules are required to run the tests.
|
Oh, it seems travis installs cssselect when running the lucid environment even though the requirements-lucid does not include cssselect: https://travis-ci.org/scrapy/scrapy/jobs/13131752#L340 Is that right? Edit: That's because the requirements are in the |
|
While travis is used to test Scrapy with specific python package versions installed as system packages in distributions (lucid and precise). But also to test most recent stable versions (latest) or development versions (trunk) of requirements.
that said, you are right about |
|
@dangra please take the lead, I'm bit busy this days. |
|
fixed as part of 6051612 |
|
Changes Unknown when pulling 1e1caa7 on darkrho:requirements into * on scrapy:master*. |
The cssselect module was missing from the requirements.txt. The mock module is needed to run one test in the tests suite, that module was already added to the travis' requirements but is missing from any requirements file in the root directory.
As is common in another projects, the
requirements-tests.txtwas created to specifically hold the modules required for running the tests. This does not include optional modules.Also,
.travis/requirements-lucid.txtwas not modified as python 2.6 support is going to be dropped and it's most likely cssselect does not work with lxml 2.2.x.