Add Tests to scrapy check command
#4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Could you resolve the conflict? |
|
Done!. Do you think this should be enough for now or am I missing anything? |
Codecov Report
@@ Coverage Diff @@
## master #4663 +/- ##
==========================================
+ Coverage 84.80% 85.14% +0.34%
==========================================
Files 163 163
Lines 9990 9990
Branches 1488 1488
==========================================
+ Hits 8472 8506 +34
+ Misses 1255 1217 -38
- Partials 263 267 +4
|
ajaymittur
changed the title
scrapy check commandscrapy check command
wRAR
approved these changes
Aug 10, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from PR #4298 which fixes #4222, added some basic tests for the
scrapy checkcommand as suggested by @Gallaecio and @elacuesta in the original issue and PR. Would like some feedback on the tests!