Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests to scrapy check command #4663

Merged
merged 7 commits into from Aug 10, 2020
Merged

Conversation

ajaymittur28
Copy link
Contributor

@ajaymittur28 ajaymittur28 commented Jul 7, 2020

Continuing from PR #4298 which fixes #4222, added some basic tests for the scrapy check command as suggested by @Gallaecio and @elacuesta in the original issue and PR. Would like some feedback on the tests!

@Gallaecio
Copy link
Member

Gallaecio commented Jul 8, 2020

Nice. Could you resolve the conflict?

@ajaymittur28
Copy link
Contributor Author

ajaymittur28 commented Jul 8, 2020

Done!. Do you think this should be enough for now or am I missing anything?

@ajaymittur28 ajaymittur28 reopened this Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #4663 into master will increase coverage by 0.34%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##           master    #4663      +/-   ##
==========================================
+ Coverage   84.80%   85.14%   +0.34%     
==========================================
  Files         163      163              
  Lines        9990     9990              
  Branches     1488     1488              
==========================================
+ Hits         8472     8506      +34     
+ Misses       1255     1217      -38     
- Partials      263      267       +4     
Impacted Files Coverage Δ
scrapy/commands/check.py 71.01% <46.15%> (+47.82%) ⬆️
scrapy/utils/trackref.py 82.85% <0.00%> (-2.86%) ⬇️
scrapy/contracts/default.py 88.46% <0.00%> (+3.84%) ⬆️

Copy link
Member

@Gallaecio Gallaecio left a comment

Awesome work!

pytest.ini Outdated Show resolved Hide resolved
@ajaymittur28 ajaymittur28 changed the title [WIP] Add Tests to scrapy check command Add Tests to scrapy check command Jul 10, 2020
@ajaymittur28 ajaymittur28 marked this pull request as ready for review Jul 10, 2020
wRAR
wRAR approved these changes Aug 10, 2020
@wRAR wRAR merged commit 0cf1340 into scrapy:master Aug 10, 2020
1 of 2 checks passed
@wRAR
Copy link
Contributor

wRAR commented Aug 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCRAPY_CHECK is not set while running contract
4 participants