Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate retry_on_eintr #4683

Merged
merged 1 commit into from Jul 16, 2020
Merged

Conversation

noviluni
Copy link
Member

@noviluni noviluni commented Jul 16, 2020

This function is not used, is not tested and is not documented, so we should probably remove it.

It was introduced to be used in test_commands.py but is not used anymore (ref: 6217f10)

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #4683 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4683      +/-   ##
==========================================
+ Coverage   85.12%   85.13%   +0.01%     
==========================================
  Files         162      162              
  Lines        9718     9719       +1     
  Branches     1438     1438              
==========================================
+ Hits         8272     8274       +2     
  Misses       1186     1186              
+ Partials      260      259       -1     
Impacted Files Coverage Δ
scrapy/utils/python.py 85.45% <100.00%> (+0.08%) ⬆️
scrapy/utils/trackref.py 85.71% <0.00%> (+2.85%) ⬆️

wRAR
wRAR approved these changes Jul 16, 2020
@Gallaecio Gallaecio merged commit b97a39f into scrapy:master Jul 16, 2020
2 checks passed
@GGXXLL
Copy link

GGXXLL commented Aug 19, 2020

Scrapyd-client use this function in scrapyd-deploy?

@Gallaecio
Copy link
Member

Gallaecio commented Aug 19, 2020

In that case they can copy it into their code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants