Tests: use classes instead of paths in settings #4817
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4817 +/- ##
==========================================
+ Coverage 87.52% 87.54% +0.02%
==========================================
Files 160 160
Lines 9761 9761
Branches 1440 1440
==========================================
+ Hits 8543 8545 +2
+ Misses 955 954 -1
+ Partials 263 262 -1
|
| @@ -56,9 +58,9 @@ class ProcessSpiderInputSpiderWithoutErrback(Spider): | |||
| custom_settings = { | |||
| 'SPIDER_MIDDLEWARES': { | |||
| # spider | |||
| __name__ + '.LogExceptionMiddleware': 10, | |||
| __name__ + '.FailProcessSpiderInputMiddleware': 8, | |||
| __name__ + '.LogExceptionMiddleware': 6, | |||
There was a problem hiding this comment.
So it looks like it currently uses only one of these entries? :)
There was a problem hiding this comment.
Indeed, the behaviour makes sense. The failing middleware fails in process_spider_input and does not define a process_spider_exception method, so LogExceptionMiddleware.process_spider_exception (the method that logs the exception) is placed at the beginning of the chain as expected. In fact, we only need one of the occurrences for the test case, I'm removing the duplicate one.
Nice catch, thanks for noticing!
There was a problem hiding this comment.
(For reference)
current master (5a38639):
Enabled spider middlewares:
['tests.test_spidermiddleware_output_chain.LogExceptionMiddleware',
'tests.test_spidermiddleware_output_chain.FailProcessSpiderInputMiddleware',
'scrapy.spidermiddlewares.httperror.HttpErrorMiddleware',
'scrapy.spidermiddlewares.offsite.OffsiteMiddleware',
'scrapy.spidermiddlewares.referer.RefererMiddleware',
'scrapy.spidermiddlewares.urllength.UrlLengthMiddleware',
'scrapy.spidermiddlewares.depth.DepthMiddleware']
current test-classes-settings (62394c2):
Enabled spider middlewares:
[<class 'tests.test_spidermiddleware_output_chain.LogExceptionMiddleware'>,
<class 'tests.test_spidermiddleware_output_chain.FailProcessSpiderInputMiddleware'>,
'scrapy.spidermiddlewares.httperror.HttpErrorMiddleware',
'scrapy.spidermiddlewares.offsite.OffsiteMiddleware',
'scrapy.spidermiddlewares.referer.RefererMiddleware',
'scrapy.spidermiddlewares.urllength.UrlLengthMiddleware',
'scrapy.spidermiddlewares.depth.DepthMiddleware']
Simplify tests after #3873