Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Windows tests on GitHub actions #4869

Merged
merged 1 commit into from Nov 5, 2020
Merged

Run Windows tests on GitHub actions #4869

merged 1 commit into from Nov 5, 2020

Conversation

elacuesta
Copy link
Member

No description provided.

@elacuesta elacuesta added the CI label Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #4869 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4869      +/-   ##
==========================================
+ Coverage   87.84%   87.86%   +0.02%     
==========================================
  Files         160      160              
  Lines        9749     9749              
  Branches     1439     1439              
==========================================
+ Hits         8564     8566       +2     
+ Misses        927      926       -1     
+ Partials      258      257       -1     
Impacted Files Coverage Δ
scrapy/core/downloader/__init__.py 92.48% <0.00%> (+1.50%) ⬆️

wRAR
wRAR approved these changes Nov 4, 2020
@Gallaecio
Copy link
Member

Gallaecio commented Nov 4, 2020

Any way we can avoid duplicate runs in pull requests? (one for push and one for pull request)

@elacuesta explained to me that this is because of this pull request coming from a branch on the same repository, which will rarely be the case.

@Gallaecio Gallaecio merged commit c292957 into master Nov 5, 2020
2 checks passed
@elacuesta elacuesta deleted the github-actions branch November 5, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants