Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OffsiteMiddleware: add 2 stats counters #566

Merged
merged 2 commits into from
Jan 31, 2014
Merged

OffsiteMiddleware: add 2 stats counters #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a54515
Offsite: add 2 stats counters
redapple Jan 28, 2014
fd5b405
Always enable offsite stats + refactor test to initialize crawler
redapple Jan 29, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scrapy/contrib/spidermiddleware/offsite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,12 @@

class OffsiteMiddleware(object):

def __init__(self, stats):
self.stats = stats

@classmethod
def from_crawler(cls, crawler):
o = cls()
o = cls(crawler.stats)
crawler.signals.connect(o.spider_opened, signal=signals.spider_opened)
return o

Expand All @@ -30,6 +33,8 @@ def process_spider_output(self, response, result, spider):
self.domains_seen.add(domain)
log.msg(format="Filtered offsite request to %(domain)r: %(request)s",
level=log.DEBUG, spider=spider, domain=domain, request=x)
self.stats.inc_value('offsite/domains', spider=spider)
self.stats.inc_value('offsite/filtered', spider=spider)
else:
yield x

Expand Down
4 changes: 3 additions & 1 deletion scrapy/tests/test_spidermiddleware_offsite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@
from scrapy.http import Response, Request
from scrapy.spider import Spider
from scrapy.contrib.spidermiddleware.offsite import OffsiteMiddleware
from scrapy.utils.test import get_crawler


class TestOffsiteMiddleware(TestCase):

def setUp(self):
self.spider = self._get_spider()
self.mw = OffsiteMiddleware()
crawler = get_crawler()
self.mw = OffsiteMiddleware.from_crawler(crawler)
self.mw.spider_opened(self.spider)

def _get_spider(self):
Expand Down