Prevent edge case that creates extra event loop #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`asyncio.get_event_loop_policy().get_event_loop() is asyncio.get_running_loop()` is not always true, as mentioned in python/cpython#96377 (comment). The AsyncioSelectorReactor runs in the second thread and uses the already initialised event loop in the main thread to run the crawler, so a single event loop will be running code from two threads.
|
I expect tests to break, we had to change this recently for a reason. Let’s see… |
wRAR
requested changes
Feb 16, 2023
Codecov Report
@@ Coverage Diff @@
## master #5832 +/- ##
==========================================
- Coverage 88.94% 88.84% -0.11%
==========================================
Files 162 162
Lines 11002 11055 +53
Branches 1798 1800 +2
==========================================
+ Hits 9786 9822 +36
- Misses 937 954 +17
Partials 279 279
|
Replace `get_asyncio_event_loop_policy` with `set_asyncio_event_loop_policy` to minimise usage of `asyncio.get_event_loop_policy`. If the issues with the default loop on Windows are resolved, `set_asyncio_event_loop_policy` will be redundant and so will all the policy functions of asyncio.
wRAR
approved these changes
Mar 5, 2023
Gallaecio
reviewed
Mar 7, 2023
Gallaecio
approved these changes
Mar 14, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5831.
asyncio.get_event_loop_policy().get_event_loop() is asyncio.get_running_loop()is not always true, as mentioned in python/cpython#96377 (comment). The AsyncioSelectorReactor runs in the second thread and uses the already initialised event loop in the main thread to run the crawler, so a single event loop will be running code from two threads.According to python/cpython#100160, we might need to replace
asyncio.get_event_loop()withasyncio.get_running_loop()if semantics change. Currently, some low level aspects of asyncio are in flux.