-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diff mode #229
Add diff mode #229
Conversation
|
@tjvr This looks great. Is there anything we can do at RPF to help move this on? The code on your PR looks pretty clear - what were you thoughts about next steps or changes that you'd like to make? |
Hello! :) I think I'm still waiting for design feedback—it's not clear what the best design is here. Specifically the colors to use for the outlines and strikethroughs. (I think we're agreed on outlines for insertions, and strikethrough for deletions.) |
@tjvr Thanks - I'll chase! |
Hello @tjvr! I'm a web designer at RPF. I have a little design feedback for you:
|
Hey, nice to meet you :-)
We did consider that, but I'm concerned opacity won't look good when printed. What do you mean by the "block being changed"? I can't imagine fading the inserted blocks would work well! :-) |
I'm going to merge this experimental diff mode to master for now :) |
Thanks @tjvr -- if this has been moved to master does that mean we can experiment with this new feature on https://scratchblocks.github.io? |
@rik-cross I shall have to work out how to rebuild it first! :-) Sent with GitHawk |
@tjvr thanks! let us know if there's anything we can do to help, we'd love to be able to use this feature. |
I added a dev page, where you can play around with the dev version :) |
@tjvr thanks for setting this up for us! 👍 |
Some early experiments at adding features for rendering "diffs".