Say/think bubble SVG templates #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulkaplan
force-pushed
the
say-think
branch
4 times, most recently
from
20400bc
to
858bea7
Compare
cwillisf
requested changes
Oct 11, 2017
src/util/svg-text-bubble.js
Outdated
| return `<text fill="#575E75">${this.lines.join('\n')}</text>`; | ||
| } | ||
|
|
||
| toString (type, text, pointsLeft) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| if (!this._textSizeCache[svgString]) { | ||
| this._textSizeCache[svgString] = this.svgRenderer.measure(svgString); | ||
| } | ||
| return this._textSizeCache[svgString]; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
cwillisf
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Describe what this Pull Request does
This PR builds on #176 (the first commit here) and two parts:
This is meant as conversation-starter code, it is still very early. The things I want to talk about w/ @cwillisf are:
svg-rendererin order to measure the width/height of the text block before creating the enveloping path. Thesvg-rendererisn't meant for this, because it also draws it to a canvas which we do not need. Is there a better way to share the measurement code, possibly drawing out and expanding theSVGMeasurementProviderused in the text wrapping code?