-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add say/think functionality to looks blocks #691
Conversation
befc477
to
4b75417
Compare
@@ -280,22 +280,33 @@ class Runtime extends EventEmitter { | |||
} | |||
|
|||
/** | |||
* Event name for glowing the green flag | |||
* Event name when threads start running. | |||
* Used by the UI to indicate running status. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one C&P error :)
src/engine/runtime.js
Outdated
* @fires Runtime#targetWasCreated | ||
*/ | ||
fireTargetWasRemoved (newTarget, sourceTarget) { | ||
this.emit('targetWasRemoved', newTarget, sourceTarget); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬
…indows Fix tests on Windows
Proposed Changes
Describe what this Pull Request does
Adds say/think bubble functionality. Depends on scratchfoundation/scratch-render#177 and scratchfoundation/scratch-render#176.