Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add say/think functionality to looks blocks #691

Merged
merged 5 commits into from
Oct 11, 2017

Conversation

paulkaplan
Copy link
Contributor

@paulkaplan paulkaplan commented Oct 5, 2017

Proposed Changes

Describe what this Pull Request does

Adds say/think bubble functionality. Depends on scratchfoundation/scratch-render#177 and scratchfoundation/scratch-render#176.

@paulkaplan paulkaplan added this to the Oct 18 milestone Oct 5, 2017
@paulkaplan paulkaplan force-pushed the say-think branch 2 times, most recently from befc477 to 4b75417 Compare October 10, 2017 19:33
@paulkaplan paulkaplan changed the title [WIP] Add say/think functionality to looks blocks Add say/think functionality to looks blocks Oct 10, 2017
@@ -280,22 +280,33 @@ class Runtime extends EventEmitter {
}

/**
* Event name for glowing the green flag
* Event name when threads start running.
* Used by the UI to indicate running status.

This comment was marked as abuse.

Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one C&P error :)

* @fires Runtime#targetWasCreated
*/
fireTargetWasRemoved (newTarget, sourceTarget) {
this.emit('targetWasRemoved', newTarget, sourceTarget);

This comment was marked as abuse.

This comment was marked as abuse.

Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬
:shipit:

@paulkaplan paulkaplan merged commit f09c4d0 into scratchfoundation:develop Oct 11, 2017
@paulkaplan paulkaplan deleted the say-think branch October 11, 2017 18:24
stefania11 pushed a commit to mitmedialab/cognimates-vm that referenced this pull request Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants