Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Say/think bubbles stop moving with sprite #728

Closed
griffpatch opened this issue Oct 23, 2017 · 0 comments · Fixed by #729
Closed

Say/think bubbles stop moving with sprite #728

griffpatch opened this issue Oct 23, 2017 · 0 comments · Fixed by #729
Assignees
Milestone

Comments

@griffpatch
Copy link
Contributor

griffpatch commented Oct 23, 2017

Expected Behavior

Say / Think bubbles always stay attached to the sprite they originated from (See: #691)

Actual Behavior

Say / Think bubble can become fixed in their position and not move with their sprite / clone

Steps to Reproduce

  • Create a stack: When Green Flag Clicked -> Move (10) steps -> Say "Hello!" for (2) seconds.
  • Click the green flag a couple of times
  • Move the sprite and watch the say block stay where it was.

image

If it helps, make the delay larger from 2 seconds :). I kind of feel the issue is to do with the promise on a timer and a new say block being instanced which the promise is still active? Perhaps the promise needs cancelling when a new say or think block is executed? However, playing around with this, it is really rather unpredictable :)

Also getting this exception in the console:

image

This test setup shows how the say until needs cancelling after another say:

image

And it also has the same issue with the "say for 2" not moving with the sprite, but the second "say for 2" actually moving ok weirdly...

Operating System and Browser

Chrome latest on windows 10

@thisandagain thisandagain added this to the Nov 15 milestone Oct 23, 2017
paulkaplan added a commit to paulkaplan/scratch-vm that referenced this issue Oct 23, 2017
This was the original issue scratchfoundation#728 that spurred these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants