This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Update ScratchX with changes that increase compatibility with Safari #103
Comments
cwillisf
pushed a commit
to cwillisf/scratchx
that referenced
this issue
Jan 4, 2017
Port LLK/scratchr2#4168 for ScratchX. Original description from that change: > This fixes #4112 by creating the swf regardless of OS and browser. > Calling `embedSWF` would first check for the existence of the plugin > before creating, causing browsers that don’t allow the flash plugin by > default to not be able to show their “allow” message. This tries to > create the swf no matter what, allowing browsers to detect flash > themselves. > > Logic is as follows: > 1. check if `userAgent` returns a mobile/tablet OS. Display error > message if so > 2. check if on windows and using ie – check for an express install if > so (like in `embedSWF`) > 3. load the swf in all other cases, let browsers handle it. > > Test Cases: > - Test how project pages load in Android and iOS devices, on tablets > and on phones, and on multiple desktop OS's for correct loading > behavior. This resolves scratchfoundation#103
cwillisf
added a commit
that referenced
this issue
Jan 5, 2017
Fix GH-103: Create SWF regardless of platform
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I believe the relevant issue in the Scratch codebase is:
https://github.com/LLK/scratchr2/issues/4112
@mewtaylor for confirmation?
The text was updated successfully, but these errors were encountered: