Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with gnome 3.32 #46

Closed
wants to merge 9 commits into from

Conversation

ChrisLauinger77
Copy link
Contributor

converted extension.js with jscodeshift
it still does not work but the error message in log changed to
TypeError: this._getApps is not a function


_getApps: function() {
_getApps() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes how _getApps() needs to be called. The changes is probably correct, but the caller on line 149 will have to be updated accordingly as well. This is probably only the first of several such errors.

@ChrisLauinger77 ChrisLauinger77 changed the title Does not work with gnome 3.32 #45 Does not work with gnome 3.32 Aug 22, 2019
@ChrisLauinger77
Copy link
Contributor Author

ChrisLauinger77 commented Aug 23, 2019

I have no idea how _getApps and _buildMenu needs to be called.
I tried to move the call outside of the constructor in function enable like:

`
function enable() {
_indicator = new MessageMenu;
_indicator._getApps();
_indicator._buildMenu();

originalUpdateCount = MessageTray.SourceActor.prototype._updateCount;
MessageTray.SourceActor.prototype._updateCount = customUpdateCount;

statusArea =  Main.panel.statusArea;

Main.panel.addToStatusArea('messageMenu', _indicator,1);

iconBox =  statusArea.messageMenu.actor;

originalStyle = iconBox.get_style();

}
`

still the same error. all code examples I found tell it should work thoug :(

@ChrisLauinger77
Copy link
Contributor Author

Now the last commit it loads but does not show an icon in upper right corner :(
Close but not quite.
Any hints where to look for that ?

@ChrisLauinger77
Copy link
Contributor Author

when I use mail-message-new-symbolic as Icon it works - the one from the /icons subdirectory from the extension does not :(
but i am happy now - extension is loaded and at least an icon is shown

@ChrisLauinger77
Copy link
Contributor Author

ChrisLauinger77 commented Sep 3, 2019

I would take the current master and create a legacy branch from it.
After that the new stuff can become master

@ChrisLauinger77
Copy link
Contributor Author

changed metadata.json to only support gnome-shell 3.32 and version to 17

@sionleroux
Copy link
Collaborator

OK, so I just checked and the version you added to metadata.json are already listed in the file in the master branch, so I'll skip the commits that modify that file, they cause conflicts anyway.

As for the rest of it, I tried it out on Arch Linux and it works as expected, I also read up a bit on ES6 classes to make sure the code is alright and it looks good to go, I'll merge this soon and it'll go out in the next release, thanks for your hard work! 💛

@sionleroux sionleroux closed this in 47433f5 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants