-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with gnome 3.32 #46
Conversation
Merge pull request #43 from hustler77/master
|
||
_getApps: function() { | ||
_getApps() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes how _getApps()
needs to be called. The changes is probably correct, but the caller on line 149 will have to be updated accordingly as well. This is probably only the first of several such errors.
I have no idea how _getApps and _buildMenu needs to be called. `
} still the same error. all code examples I found tell it should work thoug :( |
Now the last commit it loads but does not show an icon in upper right corner :( |
when I use mail-message-new-symbolic as Icon it works - the one from the /icons subdirectory from the extension does not :( |
I would take the current master and create a legacy branch from it. |
changed metadata.json to only support gnome-shell 3.32 and version to 17 |
OK, so I just checked and the version you added to metadata.json are already listed in the file in the master branch, so I'll skip the commits that modify that file, they cause conflicts anyway. As for the rest of it, I tried it out on Arch Linux and it works as expected, I also read up a bit on ES6 classes to make sure the code is alright and it looks good to go, I'll merge this soon and it'll go out in the next release, thanks for your hard work! 💛 |
converted extension.js with jscodeshift
it still does not work but the error message in log changed to
TypeError: this._getApps is not a function