feat(1415): Add subscribe field in parsed config #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jithine
approved these changes
Aug 31, 2020
jithine
reviewed
Sep 3, 2020
lib/phase/functional.js
Outdated
| @@ -223,6 +223,17 @@ module.exports = async (flattenedDoc, buildClusterFactory, triggerFactory, pipel | |||
|
|
|||
| // Workflow graph | |||
| doc.workflowGraph = await generateWorkflowGraph(doc, triggerFactory, pipelineId); | |||
|
|
|||
| doc.workflowGraph.nodes.forEach(node => { | |||
There was a problem hiding this comment.
is this needed because it get's saved with without ~ ?
There was a problem hiding this comment.
Yeah this being getting saved without ~ was causing some problems. I needed this trigger to be the same as ~pr and ~commit.
tkyi
approved these changes
Sep 8, 2020
This was referenced Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes screwdriver-cd/screwdriver#1415
Objective
This PR adds the
subscribefield to the parsed config.References
screwdriver-cd/screwdriver#1415
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.