Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(1415): Add subscribe field in parsed config #109

Merged
merged 7 commits into from
Oct 12, 2020
Merged

feat(1415): Add subscribe field in parsed config #109

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6db2d3f
feat(1415): Add subscribe field in parsed config
supra08 Aug 21, 2020
7a195ed
feat(1415): Add tests and test data
supra08 Aug 21, 2020
e8d3cb2
fix(1415): Format subscribe trigger
supra08 Sep 2, 2020
c814697
fix(1415): Fix lint in functional.js
supra08 Sep 22, 2020
9d5cf8a
fix(1415): Fix tests
supra08 Sep 23, 2020
6588405
fix(1415): Fix test data
supra08 Sep 25, 2020
214c18d
cleanup(1415): Remove console statements
supra08 Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/phase/functional.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,17 @@ module.exports = async (flattenedDoc, buildClusterFactory, triggerFactory, pipel

// Workflow graph
doc.workflowGraph = await generateWorkflowGraph(doc, triggerFactory, pipelineId);

doc.workflowGraph.nodes.forEach(node => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed because it get's saved with without ~ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this being getting saved without ~ was causing some problems. I needed this trigger to be the same as ~pr and ~commit.

if (node.name === 'subscribe')
node.name = '~subscribe'
});

doc.workflowGraph.edges.forEach(edge => {
if (edge.src === 'subscribe')
edge.src = '~subscribe'
});

errors = errors.concat(validateWorkflowGraph(doc));

// Check if build cluster annotation is valid
Expand Down