Allow for swiping between conjugation and declension views

[andrewtavis]

Terms

• I have searched open and closed feature requests
• I agree to follow Scribe-iOS' Code of Conduct

Description

This issue would add swipe functionality to the conjugation and declension views for Scribe keyboards, with the former being displayed when a user presses the conjugate key and enters a verb and the latter being displayed when a user clicks on a preposition's case to see the possible pronouns that could be used. As of now we have a left and right button to the side of the view that are used to switch views, with the goal being that the user would also be able to swipe. The left and right buttons would not be removed to make sure that the user can still understand the ability to switch views :)

The code for this would generally follow the patterns used in #337 that added swipe support to the new menu 🚀

Contribution

Happy to work on this with someone or get to it myself! 😊

[andrewtavis]

CC @SaurabhJamadagni on this :)

[andrewtavis]

CC @Taufi, can you write in here so I can assign you as well :)

[Taufi]

I would like to work with Henrik on the issue. Is this the information you need?

[andrewtavis]

Exactly, @Taufi :) As soon as you write in I can assign you. Helps us keep an overview of who's on what 😊

Let me know if there's anything I can do to help!

[Taufi]

Yes, you can help us:
Henrik and I want to add a swipe gesture recognizer to the keyboardView. We are uncertain about the optimal location for defining it. ViewDidLoad in KeyboardViewContoller seems appropriate since it's only called once. Although setConjugationBtns is closer in context to conjugation, it's called frequently. Do you have any suggestions?

[andrewtavis]

Thanks for the research so far, both of you! 🙌 Both are really good points!

Originally I was typing out that ViewDidLoad makes sense to keep the keyboard load times down, but that's also with the assumption that a person will use conjugate at least once when using Scribe. Maybe for Scribe-Desktop where someone's writing an email or a paper, but I'd say that in a typical phone interaction a person is using verbs that they generally know how to conjugate, and just need help in special circumstances. In this case I'd go with setConjugationBtns, with this also having the architectural bonus that its usage is closer to its function :)

How does this sound?

[Taufi]

Your reasoning convinces me, Andrew. I think that's how we should proceed. Many thanks for the tip.

[andrewtavis]

Many thanks for checking in, @Taufi!

[henrikth93]

Thanks for the research so far, both of you! 🙌 Both are really good points!

Originally I was typing out that ViewDidLoad makes sense to keep the keyboard load times down, but that's also with the assumption that a person will use conjugate at least once when using Scribe. Maybe for Scribe-Desktop where someone's writing an email or a paper, but I'd say that in a typical phone interaction a person is using verbs that they generally know how to conjugate, and just need help in special circumstances. In this case I'd go with setConjugationBtns, with this also having the architectural bonus that its usage is closer to its function :)

How does this sound?

Makes sense!

[andrewtavis]

Closed by #412 🥳 Thanks so much, @Taufi and @henrikth93 for the great collaboration on this!