Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for swiping between conjugation and declension views #361 #412

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

Taufi
Copy link
Contributor

@Taufi Taufi commented Apr 12, 2024

Contributor checklist


Description

The pull request provided by henrikth93 and Taufi offers a solution for issue #361: enabling swiping between conjugation and declension views. Alongside the existing left and right buttons used for view switching, users can now also swipe to navigate between views.

The fix is tested by henrikth93 and Taufi on

iPhone 12, iOS 17.3.1. (physical device)
iPhone 15, iOS 17.4. (simulator)
iPhone 15 Pro, iOS 17.0. (simulator)
iPad (10th generation), iOS 17.0 (simulator)
iPhone SE (3rd generation), iOS 17.0 (simulator)

Please note: Swipe gestures do not work with all simulators. It probably depends on whether XCode is running under Rosetta or not (https://forums.developer.apple.com/forums/thread/696832)

Related issue

Copy link

github-actions bot commented Apr 12, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review April 13, 2024 16:03
@@ -1207,6 +1207,13 @@ class KeyboardViewController: UIInputViewController {

/// Sets up all buttons and labels for the conjugation view given constraints to determine the dimensions.
func setConjugationBtns() {
// add swipe functionality to the conjugation and declension views
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note here that we want comments on their own line to be complete sentences with a period at the end :) No stress, I'll fix it 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both so much for this! Another great feature 😊 Looking forward to playing around with this when it's live!

@andrewtavis andrewtavis merged commit 40b0680 into scribe-org:main Apr 13, 2024
@Taufi Taufi deleted the swipe-conjugation branch April 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants