Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract keyboard key padding functionality from KeyboardKeys.swift #383

Closed
2 tasks done
andrewtavis opened this issue Nov 17, 2023 · 4 comments
Closed
2 tasks done

Extract keyboard key padding functionality from KeyboardKeys.swift #383

andrewtavis opened this issue Nov 17, 2023 · 4 comments
Assignees
@henrikth93
Labels
-priority- High priority refactor Refactor code to improve quality

Comments

@andrewtavis
Copy link
Member

Terms

Issue

The goal of this issue would be to move the functionality for adding padding to keyboard keys to the KeyboardKeys.swift file from the main keyboard view controller. @henrikth93 has expressed interest in this :)
@andrewtavis andrewtavis added the refactor Refactor code to improve quality label Nov 17, 2023
@andrewtavis andrewtavis changed the title Extract keyboard key padding functionality into KeyboardKeys.swift Extract keyboard key padding functionality feom KeyboardKeys.swift Dec 3, 2023
@andrewtavis andrewtavis changed the title Extract keyboard key padding functionality feom KeyboardKeys.swift Extract keyboard key padding functionality from KeyboardKeys.swift Dec 3, 2023
@andrewtavis andrewtavis added the -priority- High priority label Dec 3, 2023
@andrewtavis
Copy link
Member Author

@henrikth93, do you want to write in here so I can assign? :)

@henrikth93
Copy link
Member

@henrikth93, do you want to write in here so I can assign? :)

Sure!

@andrewtavis
Copy link
Member Author

Assigned! Let me know if we should do another check in at some point :)

@andrewtavis andrewtavis mentioned this issue Jan 13, 2024
Merged
andrewtavis added a commit that referenced this issue Jan 13, 2024
@andrewtavis
#383 formatting for keyboard key sizing functions and comments
0c721ec
@andrewtavis
Copy link
Member Author

Closed via #389 with minor formatting in 0c721ec 😊 Thanks for the continued efforts here, @henrikth93! Can't believe we're so close to having the new layouts set up! 🥳

andrewtavis added a commit that referenced this issue Jan 13, 2024
@andrewtavis
#383 update changelog with record on key width/spacing refactoring
21a7550
SaurabhJamadagni pushed a commit to marekviktor/Scribe-iOS that referenced this issue Apr 18, 2024
@andrewtavis @SaurabhJamadagni
scribe-org#383 update changelog with record on key width/spacing refa…
f34c14e 
…ctoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrikth93 henrikth93

Labels
-priority- High priority refactor Refactor code to improve quality
Projects
Scribe Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewtavis @henrikth93