Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made separate functions for key width and key padding, and adjusted t… #389

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

henrikth93
Copy link
Member

@henrikth93 henrikth93 commented Dec 22, 2023

…he layout of the expanded keyboard.

Issue #362 (This needs to be implemented for more languages, if needed)

Contributor checklist


Description

Related issue

Copy link

github-actions bot commented Dec 22, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@@ -26,7 +26,7 @@ var keyWidth = CGFloat(0)
var letterKeyWidth = CGFloat(0)
var numSymKeyWidth = CGFloat(0)
var isFirstKeyboardLoad = false

var disableAccentCharacters = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting.. 🤔 just learned that semicolons are also optional in Swift 😲
Not 100% on how y'all have been doing this, but we use SwiftLint for linting? Do we enforce linting?

Total nit hehe - the above trailing semicolon simply caught my eye, and led me to searching a bit about SwiftLint 😆 Appears like the community seems to prefer removing trailing semicolons? Not sure, but made me think about linting for us.

NOTE: no need to set any of this up in this PR 😆 just commenting as something for us to think through 👍

CC: @andrewtavis @SaurabhJamadagni

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I'd say we don't need the semicolons as well, thanks @wkyoshida! Maybe we can get ourselves one of them fancy PR linting checks 🤠 Should we make an issue for it?

Removed trailing semicolon
@wkyoshida wkyoshida mentioned this pull request Dec 28, 2023
2 tasks
widthAnchor.constraint(equalToConstant: numSymKeyWidth * 1).isActive = true
} else if ["delete", "#+=", "selectKeyboard", SpecialKeys.capsLock].contains(key) {
layer.setValue(true, forKey: "isSpecial")
widthAnchor.constraint(equalToConstant: numSymKeyWidth * scalarSpecialKeysWidth).isActive = true //*2 scalarSpecialKeysWidth = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a space between the slashes and the comment

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go through and add in the minor nitpick edit to the comment, @henrikth93 :) Thanks so much for the work here! 🥳 Let's discuss what else is needed for the main issue in the sync, but I'll close #383 once I'm done with the minor edits for this 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants