My first commit #360
My first commit #360
Conversation
Made some changes - I am not completely done - but this is a first draft.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you! Maintainer checklist
|
|
Thanks for this, @henrikth93! I edited your commit message to check off that it’s on a separate branch and to reference the issue number :) Let me know what else you’d like to work on for this issue. We can of course discuss in the weekly though 😊 |
|
From the dev sync, where we'd need to change how the keyboard layouts are being switched to is at this line here. |
| @@ -1620,7 +1633,8 @@ class KeyboardViewController: UIInputViewController { | |||
| } | |||
| } else { | |||
| letterKeyWidth = (UIScreen.main.bounds.width - 6) / CGFloat(letterKeys[0].count) * 0.9 | |||
| numSymKeyWidth = (UIScreen.main.bounds.width - 6) / CGFloat(numberKeys[0].count) * 0.9 | |||
| //If we are using expanded keys the numberKeys array is empty, we use symbolKeys | |||
There was a problem hiding this comment.
Minor note on comments, @henrikth93: when it's a full line we try to do complete sentences where we'll have a period at the end :) No stress whatsoever though!
| @@ -2454,7 +2468,8 @@ class KeyboardViewController: UIInputViewController { | |||
| capsLockPossible = true | |||
|
|
|||
| case "123", ".?123": | |||
| changeKeyboardToNumberKeys() | |||
| (usingExpandedKeyboard) == true ? changeKeyboardToSymbolKeys() : changeKeyboardToNumberKeys() | |||
There was a problem hiding this comment.
Hey @henrikth93! Definitely was not the plan to have this take a month. You have my apologies, especially as this was a very easy review :) I'll go through and make some minor changes to this and figure out where we're losing the row. Will send that along and tag the issue along with an explanation of what needed to happen.
Again thanks so much! Definitely not my norm to have things take so long, and I appreciate the understanding and support on all this 😊
Made some changes - I am not completely done - but this is a first draft.
Contributor checklist
Description
Related issue