Skip to content

Commit

Permalink
build: run acceptance tests from travis.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
@adamralph
adamralph committed Jun 14, 2014
1 parent 41a541e commit b29f65b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .travis.yml
View file
Expand Up @@ -11,8 +11,11 @@ install:
- mono ./.nuget/NuGet.exe restore ./ScriptCs.sln

script:
- mkdir artifacts --parents
- xbuild ./ScriptCs.sln /property:Configuration=Release /nologo /verbosity:normal
- mono ./packages/xunit.runners.1.9.2/tools/xunit.console.clr4.exe test/ScriptCs.Tests.Acceptance/bin/Release/ScriptCs.Tests.Acceptance.dll /xml artifacts/ScriptCs.Tests.Acceptance.dll.TestResult.xml /html artifacts/ScriptCs.Tests.Acceptance.dll.TestResult.html

notifications:
email:
- adam@adamralph.com

7 comments on commit b29f65b

@fraga
Copy link

@fraga fraga commented on b29f65b Jun 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @adamralph. The others fails probably because Moq wasn't build for mono.

@adamralph
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fraga does Moq have known problems on Mono?

@ztone
Copy link
Contributor

@ztone ztone commented on b29f65b Jun 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamralph see #756 and devlooped/moq#113. It's more a problem with Castle.Core than Moq.

@fraga
Copy link

@fraga fraga commented on b29f65b Jun 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ztone @adamralph yeah you're right. It's more of a Core problem. However, moq needs to reference the right lib too. I tried to go around and fix Core to compile on mono 3.4 https://github.com/fraga/Core/commits/fixMonoBuild , then referenced that build on Moq, compiled Moq under mono and I had more errors. Needs more work.

For the moment I think including the acceptance tests was the best approach.

@ztone
Copy link
Contributor

@ztone ztone commented on b29f65b Jun 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamralph @fraga I fixed the unit tests in ScriptCs.Core.Test (#734) to work on Mono (this lib isn't using Moq). That could be added to Travis so it won't regress.

@fraga
Copy link

@fraga fraga commented on b29f65b Jun 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I would ask you @ztone and @adamralph before creating a PR - what do you think about creating a xUnit xml project fraga@dd10e92

Added ScriptCs.Core.Test

We can also discuss this maybe in an issue :)

xunit.dll:     Version 1.9.2.1705
Test assembly: /home/travis/build/fraga/scriptcs/test/ScriptCs.Core.Tests/bin/Release/ScriptCs.Core.Tests.dll
145 total, 0 failed, 0 skipped, took 1.066 seconds
xunit.dll:     Version 1.9.2.1705
Test assembly: /home/travis/build/fraga/scriptcs/test/ScriptCs.Tests.Acceptance/bin/Release/ScriptCs.Tests.Acceptance.dll
7 total, 0 failed, 0 skipped, took 4.445 seconds
=== 152 total, 0 failed, 0 skipped, took 5.511 seconds ===

@adamralph
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the preferred approach is globbing for test projects. @jrusbatch can comment on that. However, at some point, we probably want to be able to run unit tests and acceptance tests seperately from the CLI so we may well want to move them to separate folders.

Please sign in to comment.