Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌾 Eager loading for non-relation fields #124

Merged
merged 4 commits into from
Sep 23, 2019
Merged

Conversation

erikgaal
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #124 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
+ Coverage     87.39%   87.42%   +0.03%     
- Complexity      702      708       +6     
============================================
  Files            80       80              
  Lines          2046     2052       +6     
============================================
+ Hits           1788     1794       +6     
  Misses          258      258
Impacted Files Coverage Δ Complexity Δ
src/Queries/Concerns/EagerLoadRelationships.php 100% <100%> (ø) 7 <0> (+2) ⬆️
src/Fields/Field.php 94.03% <100%> (+0.2%) 74 <3> (+3) ⬆️
src/Eloquent/ModelSchema.php 98.14% <100%> (+0.03%) 36 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34386ac...44d3106. Read the comment docs.

@erikgaal erikgaal merged commit dcf3478 into master Sep 23, 2019
@erikgaal erikgaal deleted the field-with-config branch September 23, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants