Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archimedes hard fork: Disable sha2, ripemd, blake2f precompiles #280

Merged
merged 15 commits into from May 9, 2023
Merged

Archimedes hard fork: Disable sha2, ripemd, blake2f precompiles #280

merged 15 commits into from May 9, 2023

Conversation

maxwolff
Copy link

@maxwolff maxwolff commented Apr 17, 2023 •
edited

named archimedes

support an earlier testnet release by pushing back implementation of some precompiles

tested locally as well

@maxwolff maxwolff marked this pull request as ready for review April 17, 2023 19:16
@Thegaram Thegaram marked this pull request as draft April 18, 2023 05:01
@maxwolff maxwolff changed the title comment out precompiles Remove out precompiles except for identity and ecrecover Apr 19, 2023
@maxwolff
Copy link
Author

eth/tracers/internal/tracetest/calltrace_test.go fails on develop, apparently bc selfdestruct was deprecated

makes it hard to know if this change would also break that test. just fyi

@maxwolff
Copy link
Author

did not address making changes in cmd/puppeth/genesis.go to support building an aleth config, as aleth is deprecated and we do not use it

maxwolff
maxwolff commented Apr 19, 2023
View reviewed changes
genesis_zktrie.json Outdated Show resolved Hide resolved
@maxwolff maxwolff changed the title Remove out precompiles except for identity and ecrecover Remove precompiles except for identity and ecrecover Apr 19, 2023
@maxwolff maxwolff marked this pull request as ready for review April 19, 2023 04:00
georgehao
georgehao previously approved these changes Apr 19, 2023
View reviewed changes
zimpha
zimpha previously approved these changes Apr 20, 2023
View reviewed changes
@maxwolff maxwolff dismissed stale reviews from zimpha and georgehao via 0c61871 May 1, 2023 04:05
Thegaram
Thegaram reviewed May 2, 2023
View reviewed changes
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to only disable SHA2-256, RIPEMD-160, and blake2f. Otherwise legit.

params/config.go Show resolved Hide resolved
@maxwolff maxwolff changed the title Remove precompiles except for identity and ecrecover Add hard fork that disables sha2, ripemd, blake2f precompiles May 4, 2023
Thegaram
Thegaram previously approved these changes May 8, 2023
View reviewed changes
params/config.go Outdated Show resolved Hide resolved
eth/tracers/js/tracer_test.go Show resolved Hide resolved
@Thegaram Thegaram changed the title Add hard fork that disables sha2, ripemd, blake2f precompiles Archimedes hard fork: Disable sha2, ripemd, blake2f precompiles May 9, 2023
@maxwolff maxwolff merged commit b0b0bf1 into develop May 9, 2023
4 checks passed
@maxwolff maxwolff deleted the remove-precompiles branch May 9, 2023 16:04
@Thegaram Thegaram mentioned this pull request May 19, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimpha zimpha zimpha approved these changes

@Thegaram Thegaram Thegaram approved these changes

@georgehao georgehao georgehao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxwolff @zimpha @georgehao @Thegaram