Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error for disabled precompile calls #337

Merged
merged 4 commits into from May 24, 2023
Merged

Return error for disabled precompile calls #337

merged 4 commits into from May 24, 2023

Conversation

Thegaram
Copy link

1. Purpose or design rationale of this PR

In #280 we disabled the sha2, ripemd160, blake2f precompiles as part of the Archimedes hard fork.

However, simply removing the precompiles will lead to accounts that just behave as normal non-contract accounts. That means that calling these precompiles will always succeed. This might lead to unexpected silent failures for dapps that rely on these precompiles.

In this PR I propose temporarily replacing these 3 precompiles with with another precompile that simply reverts.

> cast call --rpc-url "$SCROLL_L2_DEPLOYMENT_RPC" 0x0000000000000000000000000000000000000003 --data 0xaabb
Error: 
(code: -32000, message: sha256, ripemd160, blake2f precompiles temporarily disabled, data: None)

2. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

@Thegaram Thegaram marked this pull request as ready for review May 22, 2023 07:19
@Thegaram Thegaram merged commit 334892a into develop May 24, 2023
4 checks passed
@Thegaram Thegaram deleted the archimedes-v2 branch May 24, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants