refactor(trace): wrap the core routine in CreateTraceEnv
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With scroll-tech/zkevm-circuits#746 being merged, the new wrapping method has been stable If merge, please DO NOT remove current branch immediately. We need to kept the commit which is referred in zkevm-circuit now |
HAOYUatHZ
changed the title
CreateTraceEnv
HAOYUatHZ
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR induce a new entry
CreateTraceEnvDirect, which wrap the core process inCreateTraceEnvso developer (thegeth_utilin zkevm-circuit) can use the moredirectentry for creating the trace enviroment and tailor it laterRegression test has been made by dumping some traces (uniswapv2) and passing the mock prove in supercircuit