refactor(trace): wrap the core routine in CreateTraceEnv
#460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR induce a new entry
CreateTraceEnvDirect
, which wrap the core process inCreateTraceEnv
so developer (thegeth_util
in zkevm-circuit) can use the moredirect
entry for creating the trace enviroment and tailor it laterRegression test has been made by dumping some traces (uniswapv2) and passing the mock prove in supercircuit