Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat)all: add EIP-1153 - transient storage #721

Merged
merged 13 commits into from
Apr 28, 2024
Merged

Conversation

NazariiDenha
Copy link

1. Purpose or design rationale of this PR

Add EIP-1153 transient storage and enable at Curie

https://eips.ethereum.org/EIPS/eip-1153
https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/cancun.md
https://www.notion.so/scrollzkp/Add-tload-tstore-opcodes-to-l2geth-8a54dbbcdb894ebd8e6d9c4d46b6de9a?pvs=4

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

tynes and others added 6 commits April 25, 2024 11:59
Implements TSTORE and TLOAD as specified by the following EIP:

https://eips.ethereum.org/EIPS/eip-1153
https://ethereum-magicians.org/t/eip-1153-transient-storage-opcodes/553

Co-authored-by: Sara Reynolds <snreynolds2506@gmail.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
* core/vm: move TSTORE,TLOAD to correct opcode nums

* core/vm: cleanup
@HAOYUatHZ
Copy link
Member

why do we need the change in core/blockchain_test.go?

@NazariiDenha
Copy link
Author

because our core/chain_makers.go is not fully sync with geth, so I made it like in other places, for example here

core/blockchain_test.go Outdated Show resolved Hide resolved
@HAOYUatHZ
Copy link
Member

PR LGTM but the CI looks a bit weird

@NazariiDenha
Copy link
Author

locally test works

CI fails here with blockchain_test.go:3693: failed to insert into chain: invalid block payload size

It's strange, because TestChainConfig has MaxTxPayloadBytesPerBlock set to nil, so check here and here should pass

core/blockchain_test.go Show resolved Hide resolved
core/blockchain_test.go Show resolved Hide resolved
core/blockchain_test.go Show resolved Hide resolved
Copy link
Member

@HAOYUatHZ HAOYUatHZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thegaram Thegaram merged commit 3592139 into develop Apr 28, 2024
7 checks passed
@Thegaram Thegaram deleted the 1153-transient-storage branch April 28, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants