Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-sync-service): support codecv2 #726

Merged
merged 80 commits into from
May 30, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Apr 26, 2024

1. Purpose or design rationale of this PR

  • Updating image building Dockerfiles.
  • Updating da-codec dependency.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

.gitignore Outdated Show resolved Hide resolved
rollup/types/encoding/codecv1/codecv1.go Show resolved Hide resolved
rollup/types/encoding/codecv1/codecv1.go Show resolved Hide resolved
@colinlyguo colinlyguo changed the title feat(codecv1): support zstd compression feat(codecv1): support curie batch hash change Apr 29, 2024
@colinlyguo colinlyguo changed the title feat(codecv1): support curie batch hash change feat(codecv1): support Curie batch hash change Apr 29, 2024
@colinlyguo colinlyguo force-pushed the feat-codecv1-support-zstd branch 2 times, most recently from 765efe6 to 6d5a532 Compare April 29, 2024 15:01
@colinlyguo colinlyguo force-pushed the feat-codecv1-support-zstd branch 4 times, most recently from 55b8053 to def8f9c Compare May 2, 2024 11:44
@colinlyguo
Copy link
Member Author

met this CI error, thus bumping the golang version in CI to 1.21.x.

Error: warning: geth-utils@0.1.0: /home/runner/go/pkg/mod/github.com/ethereum/go-ethereum@v1.13.5-0.20240402092557-0bd03dbc5597/common/prque/lazyqueue.go:20:2: package cmp is not in GOROOT (/opt/hostedtoolcache/go/1.20.14/x64/src/cmp)
warning: geth-utils@0.1.0: note: imported by a module that requires go 1.21
Error: warning: geth-utils@0.1.0: /home/runner/go/pkg/mod/github.com/ethereum/go-ethereum@v1.13.5-0.20240402092557-0bd03dbc5597/log/format.go:6:2: package log/slog is not in GOROOT (/opt/hostedtoolcache/go/1.20.14/x64/src/log/slog)
warning: geth-utils@0.1.0: note: imported by a module that requires go 1.21
Error: warning: geth-utils@0.1.0: /home/runner/go/pkg/mod/github.com/ethereum/go-ethereum@v1.13.5-0.20240402092557-0bd03dbc5597/rlp/typecache.go:21:2: package maps is not in GOROOT (/opt/hostedtoolcache/go/1.20.14/x64/src/maps)
warning: geth-utils@0.1.0: note: imported by a module that requires go 1.21
Error: warning: geth-utils@0.1.0: /home/runner/go/pkg/mod/github.com/ethereum/go-ethereum@v1.13.5-0.20240402092557-0bd03dbc5597/metrics/sample.go:6:2: package slices is not in GOROOT (/opt/hostedtoolcache/go/1.20.14/x64/src/slices)
warning: geth-utils@0.1.0: note: imported by a module that requires go 1.21

@colinlyguo colinlyguo changed the title feat(codecv1): support Curie batch hash change feat(codecv1): support codecv2 May 3, 2024
@colinlyguo colinlyguo changed the title feat(codecv1): support codecv2 feat(rollup-sync-service): support codecv2 May 3, 2024
Thegaram
Thegaram previously approved these changes May 5, 2024
go.mod Outdated Show resolved Hide resolved
rollup/rollup_sync_service/libzstd/src/lib.rs Outdated Show resolved Hide resolved
@colinlyguo colinlyguo requested a review from georgehao May 6, 2024 06:05
@colinlyguo colinlyguo requested a review from georgehao May 29, 2024 10:20
georgehao
georgehao previously approved these changes May 29, 2024
georgehao
georgehao previously approved these changes May 29, 2024
colinlyguo and others added 2 commits May 29, 2024 18:30
* upgrade libzkp

* remove zktrie.so

* done

* fix build

---------

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
@colinlyguo colinlyguo merged commit b091e4f into develop May 30, 2024
8 checks passed
@colinlyguo colinlyguo deleted the feat-codecv1-support-zstd branch May 30, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants