Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ccc): revert libzkp version back to v0.10.5 #785

Merged
merged 7 commits into from
May 30, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented May 30, 2024

1. Purpose or design rationale of this PR

Accidentally merged testing version libzkp, could block other features' testing.
This reverts commit 522882c.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

@colinlyguo colinlyguo changed the title feat: revert libzkp update feat: revert libzkp version back to v0.10.5 May 30, 2024
@colinlyguo colinlyguo changed the title feat: revert libzkp version back to v0.10.5 feat(ccc): revert libzkp version back to v0.10.5 May 30, 2024
HAOYUatHZ
HAOYUatHZ previously approved these changes May 30, 2024
omerfirmak
omerfirmak previously approved these changes May 30, 2024
This reverts commit 9f329ee.
@colinlyguo
Copy link
Member Author

make geth in this PR also tested (adding libzktrie.so back).

@colinlyguo colinlyguo merged commit aae829c into develop May 30, 2024
8 checks passed
@colinlyguo colinlyguo deleted the revert-libzkp-update branch May 30, 2024 07:02
lispc added a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants