Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make commit retry logic selective #788

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented May 30, 2024

1. Purpose or design rationale of this PR

Sequencer only expects an error to happen at VerifyHeader step, if we receive errors at any other step; do not retry because it is most probably won't result in success the next time.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak omerfirmak force-pushed the omerfirmak/commit-retry branch 3 times, most recently from f59bc54 to cb9ea20 Compare May 30, 2024 14:32
@omerfirmak omerfirmak marked this pull request as draft May 30, 2024 14:34
@omerfirmak omerfirmak marked this pull request as ready for review May 30, 2024 15:42
miner/scroll_worker.go Show resolved Hide resolved
miner/scroll_worker.go Show resolved Hide resolved
miner/scroll_worker.go Show resolved Hide resolved
@omerfirmak omerfirmak merged commit 36d7325 into develop May 31, 2024
7 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/commit-retry branch May 31, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants